Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Some commits (force push, update with main?) trigger wrong reviewer requests & labelling #5657

Open
svrnm opened this issue Nov 21, 2024 · 2 comments
Labels
CI/infra CI & infrastructure

Comments

@svrnm
Copy link
Member

svrnm commented Nov 21, 2024

I saw this happening a few times now, but I am not 100% sure how this happens, and we need to investigate:

if a contributor updates their PR with the latest main (force push for example), sometimes the actions for labelling and requesting reviews get triggered in a way that they request reviews and add labels across all files that have been part of that rebase. I am not 100% sure how to address that, but I wanted to record it as a bug.

Example: #5575

Screenshot 2024-11-21 at 09 54 08

Run examples:
https://github.com/open-telemetry/opentelemetry.io/actions/runs/11949606337/job/33309393503?pr=5575

Related bug in the labeler action:

actions/labeler#784

@svrnm
Copy link
Member Author

svrnm commented Nov 21, 2024

We might want to restrict the action types in the workflow files, e.g. exclude synchronize ("A pull request's head branch was updated. For example, the head branch was updated from the base branch or new commits were pushed to the head branch."), via https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=synchronize#pull_request

@svrnm
Copy link
Member Author

svrnm commented Nov 21, 2024

By default, a workflow only runs when a pull_request_target event's activity type is opened, synchronize, or reopened.

So we should change that to opened and reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: No status
Development

No branches or pull requests

1 participant