Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protobuf-java versions cause generated code to fail to compile #191

Open
andrewparmet opened this issue Aug 31, 2023 · 1 comment
Open

Comments

@andrewparmet
Copy link
Collaborator

build/generated-sources/main/protokt/com/toasttab/protokt/descriptor.kt:1290:13 Platform declaration clash: The following declarations have the same JVM signature (setRepeated(Ljava/lang/Boolean;)V):
    fun `<set-isRepeated>`(`<set-?>`: Boolean?): Unit defined in com.toasttab.protokt.ExtensionRangeOptions.Declaration.DeclarationDsl
    fun `<set-repeated>`(`<set-?>`: Boolean?): Unit defined in com.toasttab.protokt.ExtensionRangeOptions.Declaration.DeclarationDsl
@connormcauliffe-toast
Copy link

connormcauliffe-toast commented Sep 26, 2023

They added a new field to replace is_repeated in the Declaration proto inside the ExtensionRangeOptions and named it repeated, which in Kotlin both generate the same setter for Java. They removed the field in 3.24.0+ protocolbuffers/protobuf@96c601d
Would love to get #195 merged to move over the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants