Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docserv-write-xslt-param-file with Python code #296

Open
tomschr opened this issue Mar 26, 2024 · 0 comments
Open

Replace docserv-write-xslt-param-file with Python code #296

tomschr opened this issue Mar 26, 2024 · 0 comments
Labels
cleanup Clean up the code!

Comments

@tomschr
Copy link
Contributor

tomschr commented Mar 26, 2024

Situation

The scriptdocserv-write-xslt-param-file is a separate script and is called inside Docserv. It writes XSLT parameters into a file for daps2docker.

This design has some issues:

  • It's inefficient as the internal state needs to be passed to the script (that's why it takes many options)
  • Bash is slower than pure Python code

Proposed solution

  • Integrate the functionality into Docserv code as Python.
  • If really needed, provide a Python script that calls the internal code.
@tomschr tomschr added the cleanup Clean up the code! label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Clean up the code!
Projects
None yet
Development

No branches or pull requests

1 participant