Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on a "production" database #2256

Open
1 of 2 tasks
bear454 opened this issue Nov 19, 2018 · 3 comments
Open
1 of 2 tasks

Test on a "production" database #2256

bear454 opened this issue Nov 19, 2018 · 3 comments
Labels
feature 💡 For something new in the app need feedback ❓ Do not start working on it until a decision is reached

Comments

@bear454
Copy link
Contributor

bear454 commented Nov 19, 2018

I'm submitting a ..

  • Bug Report
  • Feature Request

Current behavior:

Continuous testing on Travis CI is run on a Sqlite3 database; as of filing this issue, running our test suite on either MariaDB or Postgres results in intermittent failures.

Expected correct behavior:

Travis CI runs on either MariaDB or Postgres, without introducing flakiness.

Other information:

Introduced in #2225.

@Ana06 Ana06 added feature 💡 For something new in the app need feedback ❓ Do not start working on it until a decision is reached and removed Grooming labels Feb 21, 2019
@Ana06
Copy link
Member

Ana06 commented Feb 21, 2019

@bear454 we could run travis twice with a different database. Would you like to set this up? You would need to fix the failures, but after that we would ensure that this keep working in every PR. 🤔

@hennevogel
Copy link
Member

@Ana06 read the discussion in #2225

@AndrewKvalheim
Copy link
Member

Tests are passing reliably for me on PostgreSQL after merging:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 For something new in the app need feedback ❓ Do not start working on it until a decision is reached
Projects
None yet
Development

No branches or pull requests

4 participants