-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a ready-to-use Docker Image of the Portal #124
Comments
Docker Hub does not allow "free" orgs any more. They only provide payed plans now. Thus, let's use the "Github Package Registy" to host our images:
Github Actions: |
For a web based flasher I've created also a container that hosts all static content, can be directly exposed as https://install.openbikesensor.org/ or might be integrated into the portal? We need to think about it, whichever is better to maintain. For a new version of the firmware a new container is needed, since it is only needed for the initial esp flash, updating to the latest release is not "urgent". The container is build as described above but not pushed to the registry yet. Background for the container: openbikesensor/OpenBikeSensorFirmware#275 cc @opatut |
We could try out the github registry with the very simple flasher image. Then, if that works, we can consider building a docker image in github CI for the portal. For integrating the ESP flashing logic into the portal I'd make another ticket -- for later. Until then I'm happy to set up an install page from your image. |
So the image with the installer is now at ghcr.io/openbikesensor/openbikesensorflasher:main build with https://github.com/openbikesensor/OpenBikeSensorFlasher - with every commit. |
I would also suggest to face a longterm development with split components. |
That sounds contradictory, why would you want an "all in one" image that gives you a whole cluster with proxies and load balancing and whatnot? I don't understand what the purpose of this would be. IMO, you would either:
Also I don't think it makes sense to integrate the DB and the keycloak into the image, as there are well maintained images of these components available and you'll need to manually manage them anyway, even in the simple setup. You can't just have "a default installation" of keycloak -- it needs your manual intervention to be your keycloak. Same for the DB. I would rather treat them as "external services" that the portal connect to, than part of the portal itself. |
You need to split dev and prod. |
Let's provide a ready-to-use docker image of the new portal on Docker Hub. Like this, thus the deployment of a portal is much easier and requires the use of only 3 images:
The build of the image can be handled by Docker Hubs Automated Builds:
The text was updated successfully, but these errors were encountered: