Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"as" comparatives broken in unit test #166

Open
linas opened this issue Aug 28, 2014 · 4 comments
Open

"as" comparatives broken in unit test #166

linas opened this issue Aug 28, 2014 · 4 comments

Comments

@linas
Copy link
Member

linas commented Aug 28, 2014

See bug #155 and the comments there for

The kick was as soft as the first.
He is as smart as I ever expected him to be

which should probably be:

as(taste, do)
as(run, do)
as(soft, first)
as(smart, be)

@ruiting
Copy link
Contributor

ruiting commented Aug 29, 2014

@linas As I commented on #149, I was thinking to represent the "as" comparatives the similar way as "than" comparatives, i.e. using "as" to connect the two comparison entities, the same way as "than" from the than-comparatives sentences. So according to the current representations, the sentence

The kick was softer than the first.

will be represented as:

_comparative(soft, kick)
than(kick, first)
degree(soft, comparative)

right?

so, for the sentence "The kick was as soft as the first." can be represented:

_comparative(soft, kick)
as(kick, first)

Does it make sense to you?

@linas
Copy link
Member Author

linas commented Aug 29, 2014

Oh, yes, right, makes perfect sense. The _predadj(kick, soft) confused me. Do you want _comparative(soft, kick) in addition to the predadj, or instead of it?

linas added a commit that referenced this issue Aug 29, 2014
@linas
Copy link
Member Author

linas commented Aug 29, 2014

anyway, the stuff that is currently in the unit test for these comparatives is wrong and/or unreviewd. And relex is probably broken for these, anyway ...

@ruiting
Copy link
Contributor

ruiting commented Sep 1, 2014

I think we need both _predadj(kick, soft) and _comparative(soft, kick), as they will generate different logic representation for different meanings...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants