Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RelEx to maven #267

Closed
vsbogd opened this issue Jul 14, 2018 · 6 comments
Closed

Migrate RelEx to maven #267

vsbogd opened this issue Jul 14, 2018 · 6 comments

Comments

@vsbogd
Copy link
Contributor

vsbogd commented Jul 14, 2018

See second part of the #100 (comment).

Maven can manage most of dependencies automatically so it will simplify build procedure.
It has a plugin to automate ready to run environment createion (see #266)

@noskill
Copy link

noskill commented Sep 9, 2018

Anything else to do here?

@vsbogd
Copy link
Contributor Author

vsbogd commented Sep 9, 2018

It is needed to create maven artifacts to replace manually written scripts like opencog-server.sh and relation-extractor.sh. In fact all of *.sh scripts in the root project folder.

@linas
Copy link
Member

linas commented Sep 9, 2018 via email

@vsbogd
Copy link
Contributor Author

vsbogd commented Sep 10, 2018

Actually I thought about it again and looks like the simplest way is to collect all of the dependencies in one folder using maven and then use them as classpath in existing scripts. Then scripts themselves will not be changed, only classpath will be.

I have raised #276 to collect dependencies. And I see the following further steps:

  • fix classpath in *.sh scripts to use ./target/lib/*.jar files collected by maven; I already committed it see vsbogd@57930c0 but this work cannot be merged without next steps.
  • edit docker/Dockerfile to use maven to build relex within docker image
  • update README.md
  • remove ant scripts

@linas
Copy link
Member

linas commented Sep 19, 2019

Is the work here finished? Can this be closed?

@vsbogd vsbogd closed this as completed Sep 20, 2019
@vsbogd
Copy link
Contributor Author

vsbogd commented Sep 20, 2019

Yes, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants