Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Parity Ethereum Network Trust Wallet Integration #9959

Closed
Dycedlp opened this issue Nov 24, 2018 · 1 comment
Closed

Parity Ethereum Network Trust Wallet Integration #9959

Dycedlp opened this issue Nov 24, 2018 · 1 comment
Labels
Z9-invalid 👮‍♀️ Issue is invalid. Closer should comment why.
Milestone

Comments

@Dycedlp
Copy link

Dycedlp commented Nov 24, 2018

  • Parity Ethereum version: 1.27.2
  • Operating system: Linux
  • Installation: ubuntu 16
  • Fully synchronized: no / yes
  • Network: ethereum (private)
  • Restarted: yes

--warp --tracing=on --fat-db=on --pruning=archive --no-discovery --config /ethereum/poa/node1.toml --min-gas-price 0 --ws-interface all --ws-origins all --ws-hosts all
node.toml:
[parity]
chain = "privatepoa-spec.json"
base_path = "
/ethereum/poa/node1/"
[network]
port = 30301
[rpc]
port = 8547
apis = ["web3", "eth", "net", "personal", "parity", "parity_set", "traces", "rpc", "parity_accounts"]
cors = ["null","localhost:3000","localhost:3001","http://remix.ethereum.org","chrome-search://ae62fc16-c916-4c24-9a36-97f5a850f25c","all","https://www.myetherwallet.com/"]
interface = "all" #external access to rpc
hosts = ["all"]
[ui]
port = 8181
[websockets]
disable = false
port = 8456
[ipc]
disable = false
[account]
unlock = ["0x0496632f490cb4fbe6559d202120a6fd332442e7"]
password = ["node.pwds"]
[mining]
engine_signer = "0x0496632f490cb4fbe6559d202120a6fd332442e7"
reseal_on_txs = "none"

Replacing the network to my own private network works perfectly through Trust Wallet, but doesn't update the transaction pending initial messages for some reason. I was told it was due to a web socket issue but I attempted to fix it with no luck. Is there any reason this wouldn't work? Where exactly would the check be from to confirm it?


I believe it to be here.
In Trust Wallet:
(Trust/Core/Network/Transactions/EthereumTransactionsProvider.swift)

func update(for transaction: Transaction, completion: @escaping (Result<(Transaction, TransactionState), AnyError>) -> Void) {
let request = GetTransactionRequest(hash: transaction.id)
Session.send(EtherServiceRequest(for: server, batch: BatchFactory().create(request))) { [weak self] result in
guard let self = self else { return }
switch result {
case .success(let tx):
guard let newTransaction = Transaction.from(initialTransaction: transaction, transaction: tx, coin: self.server.coin) else {
return completion(.success((transaction, .pending)))
}
*** if newTransaction.blockNumber > 0 { ***
self.getReceipt(for: newTransaction, completion: completion)
}


I believe it to be missing the part surrounded in ***'s.
Any help would be useful on this issue, thanks.

@jam10o-new
Copy link
Contributor

Hey @Dycedlp, this looks like an issue with Trust Wallet, not parity-ethereum. As mentioned in trustwallet/trust-wallet-ios#907 and stated correctly by you, these pending transactions are included in the blockchain, but trust isn't seeing them.

There is no parity-ethereum "1.27.2", is this a version of Trust?

I would comment on that issue/ create a new issue in a TrustWallet repository with your findings.

@jam10o-new jam10o-new added the Z9-invalid 👮‍♀️ Issue is invalid. Closer should comment why. label Nov 24, 2018
@5chdn 5chdn added this to the 2.3 milestone Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z9-invalid 👮‍♀️ Issue is invalid. Closer should comment why.
Projects
None yet
Development

No branches or pull requests

3 participants