Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the origin to start at 0? #295

Open
SHAESEN2 opened this issue Dec 27, 2021 · 3 comments
Open

Force the origin to start at 0? #295

SHAESEN2 opened this issue Dec 27, 2021 · 3 comments
Assignees
Labels
issue Used for project filtering

Comments

@SHAESEN2
Copy link
Collaborator

Currently ggplot has an offset to start their labels. Is this considered good practice? Personally I would not like to see such plots when quantiles are added as it is difficult to see at which times these quantiles are reached. I propose to start at the true origin using + scale_x_continuous(expand = c(0, 0)) + scale_y_continuous(expand = c(0, 0)) in visR
@cschaerfe @bailliem @timtreis

image

@SHAESEN2 SHAESEN2 added the issue Used for project filtering label Dec 27, 2021
@bailliem
Copy link
Collaborator

I agree. I think this is related to the general defaults. See in the discussion here:
https://statmodeling.stat.columbia.edu/2020/05/07/make-andrew-happy-ggplot-trick-axis-at-zero/

Happy to override the ggplot defaults.

@timtreis
Copy link
Collaborator

Personally very much in favour of this, but I feel like this borders into the previous discussion we had about changing defaults in plots, no? Back then we decided against applying a better default ggplot theme as to not surprise the user with styling that was not actively asked for. If we take the step to adjust the lower axis limits, I think we can sneak in a better theme there as well.

@SHAESEN2
Copy link
Collaborator Author

Let us go with the expand option into visr.survfit and apply theme_bw as it originally was if everyone agrees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue Used for project filtering
Projects
None yet
Development

No branches or pull requests

4 participants