-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patellofemoral range in Rajagopal model #178
Comments
Hi @mrrezaie, thanks for pointing this out. I usually reduce the range on this coordinate manually via |
I don't think the model was designed with this use case in mind. The range entered for the patellofemoral joint is immaterial if it's constrained to be equal to the knee joint angle in OpenSim. If possible, could the problem in Moco be simplified so that the knee joint and patellofemoral joint share a single state variable? (I presume what happens now is that both angles are design variables and are enforced by a constraint to be equal?) |
In this case that might be possible, but in general such simplifications would be tricky or not possible. Currently, we enforce kinematic constraints directly in Moco.
My point wasn't that these curves wouldn't overlap with a narrowing range for the patella coordinate, but rather is there any value in allow dependent coordinates to have wider ranges than their "expected" ranges during simulation. During forward integration, Simbody corrects coordinates that do not lie on the constraint manifold using a projection, during which the coordinate might lie outside of its bounds. However, I doubt the coordinate bounds are enforced during integration or coordinate projection anyway. |
Hi @nickbianco,
In the
Rajagopal2016.osim
model, thewalker_knee
joint is ranged between 0 and 2.0944 Radians, and thepatellofemoral
joint, which is constrained as a function of knee motion, is defined to be in [-99999, -99999] range. Accordingly, OpenSim Moco uses this huge range for patellofemoral joint bound, while its actual range is [0, 2.0944]. This range can be confirmed by:I just tested this new range for the bound of the patellofemoral joint in OpenSim MocoTrack, i.e. [0, 2.0944] (exactly the same as the knee), and the convergence time of a torque-driven marker tracking simulation reduced from 00:10:19 (535 iter) to 00:06:53 (347 iter) (4 threads). So, adjusting this range in the official model, as well as in the Moco examples, could be beneficial.
Thank you in advance.
The text was updated successfully, but these errors were encountered: