Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit use of CustomJoints in distributed models #45

Open
aseth1 opened this issue Jan 29, 2018 · 1 comment
Open

Limit use of CustomJoints in distributed models #45

aseth1 opened this issue Jan 29, 2018 · 1 comment

Comments

@aseth1
Copy link
Member

aseth1 commented Jan 29, 2018

CustomJoint is very flexible and intended to model complex joint types, but of course it can be used to model simpler joints like revolute, planar and gimbal joints. However, it is about 2x slower and adds unnecessary complexity to the model (and model file). A PinJoint, PlanarJoint, etc... are more compactly represented and easier to understand.

Newly distributed models, like Rajagopal2015 (#35), in 4.0 should be updated to limit the use of CustomJoints to joints that require coupling between rotational and translational spatial motion (like the knee).

@apoorvar
Copy link
Member

On a related note - I remember when building my model that using a Ball Joint vs. a Gimbal Joint for the hip lead to slightly different behaviors in the plotter. Because of the different implementations, there were differences in how moment arm was computed, and I believe there were issues in calculating muscle-tendon lengths. It may be worth adding some documentation somewhere (maybe in the User's Guide) teaching users the difference between the two and when to use which implementation.

@jenhicks jenhicks added this to the Future Release milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants