Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry directory contains several versions of several meshes, and filenames are not sufficiently descriptive #73

Open
tkuchida opened this issue May 16, 2018 · 2 comments

Comments

@tkuchida
Copy link
Member

For example, the 5 tibia files are

  • l_tibia.vtp
  • r_tibia.vtp
  • tibia.vtp
  • tibia_l.vtp
  • tibia_r.vtp

What's the difference between "r_tibia" and "tibia_r"? For which leg is the generic "tibia" intended? Cleaning up this directory and using descriptive filenames might help prevent issues like #2.

@jimmyDunne jimmyDunne mentioned this issue May 16, 2018
@jimmyDunne
Copy link
Member

I have updated the tibia files in #74. I will investigate the femur geometries in a subsequent PR. Thanks, Tom.

@tkuchida tkuchida changed the title Geometry directory contains 5 tibias, 5 femurs, etc. and filenames are not sufficiently descriptive Geometry directory contains several versions of several meshes, and filenames are not sufficiently descriptive Jun 19, 2018
@tkuchida
Copy link
Member Author

Re-opening, as this Issue affects many meshes (5 femur, 7 clavicle, 6 humerus, 6 radius, 19 "fingers", etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants