Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '_Simbody' from gait model names #75

Open
jimmyDunne opened this issue May 17, 2018 · 3 comments
Open

Remove '_Simbody' from gait model names #75

jimmyDunne opened this issue May 17, 2018 · 3 comments

Comments

@jimmyDunne
Copy link
Member

jimmyDunne commented May 17, 2018

I would like to remove the _simbody from gait2392 and gait2354. I'm sure there was a reasonable reason to differentiate them way back when, but now they are inconsistent from every other model— every model is a Simbody model.

This change would involve converting the (i) names of the models in the repo, (ii) setup files, and (iii) the Cmake lists. Externally I would update the documentation with the improved, shorter name.

I am looking for comment before I make a branch and do the conversions.

@tkuchida
Copy link
Member

I agree with removing the "_simbody" suffix.

@chrisdembia
Copy link
Member

I agree.

@jimmyDunne
Copy link
Member Author

PR #79 has dealt with this.

@jenhicks jenhicks added this to the Future Release milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants