Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lite 版本缺乏代码对比能力 #53

Open
czz362100 opened this issue Mar 31, 2023 · 3 comments
Open

lite 版本缺乏代码对比能力 #53

czz362100 opened this issue Mar 31, 2023 · 3 comments

Comments

@czz362100
Copy link

业务背景:
团队规划做一个cr工具,希望lite版本可以提供代码对比能力。

@AhkunTa
Copy link
Member

AhkunTa commented Mar 31, 2023

CR工具业务能力比较高度自定义,目前内部集成的gitLens插件和gitGraph插件虽然有对比功能,但想完成CR具体能力还是很勉强

CR能力首先要对文件树做重构,其次CR通常会带评论内容 可以参考 opensumi 内部评论模块,代码对比利用内部编辑器打开diffEditor,整体能力实现需要对 opensumi 有深入了解,有一个gitlink的CR场景可以参考下 gitlink
需要创建项目,并自己创建PR才能看到如下图
截屏2023-03-31 19 24 06

@czz362100
Copy link
Author

请问这个diffEditor需要额外集成sumi哪些模块么?

@erha19
Copy link
Member

erha19 commented Apr 3, 2023

@czz362100 diffEditor 的能力在框架内默认是支持的,不需要额外集成,接入类似 eamodio.gitlens 的插件可以实现部分效果(例如里面的 compare commits 功能就是代码对比最常见的形态),但如果是针对业务设计的工具,如上面提到的,你还得自行对接内部代码仓库接口,使用 comment 模块实现评论功能等诸多定制。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants