Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background entry animation ignored #698

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix background entry animation ignored #698

wants to merge 2 commits into from

Conversation

Massi-X
Copy link

@Massi-X Massi-X commented Jun 18, 2024 •
edited
Loading

Fixes #697

@Massi-X
Do not add animation on create
052818b 
Because it won't work when calling show() then
@Massi-X
Fix entry transition
21263cf 
Correctly apply open transition (by adding cc--anim class) on show of the consent popup
@vercel Vercel
Copy link

vercel bot commented Jun 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cookieconsent-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:57pm

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for cookieconsentv3-playground canceled.

Name Link
🔨 Latest commit 21263cf
🔍 Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/667202b760811900087fec65

@Massi-X Massi-X mentioned this pull request Jun 18, 2024
Open
@stale Stale
Copy link

stale bot commented Jul 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 18, 2024
@Massi-X
Copy link
Author

Massi-X commented Jul 18, 2024

Up!

@stale stale bot removed the stale label Jul 18, 2024
@stale Stale
Copy link

stale bot commented Aug 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 19, 2024
@Massi-X
Copy link
Author

Massi-X commented Aug 19, 2024

Re-up!

@stale stale bot removed the stale label Aug 19, 2024
@stale Stale
Copy link

stale bot commented Sep 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 18, 2024
@Massi-X
Copy link
Author

Massi-X commented Sep 19, 2024

Up

@stale stale bot removed the stale label Sep 19, 2024
@stale Stale
Copy link

stale bot commented Oct 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 19, 2024
@Massi-X
Copy link
Author

Massi-X commented Oct 19, 2024

Up!

@stale stale bot removed the stale label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Background entry animation ignored
1 participant
@Massi-X