Speedup update

[onokatio]

I notice that, zi update calls git-remote-https for 2 times.

$ GIT_TRACE=1 zi update -v zsh-users/zsh-completions
22:51:44.486501 git.c:460               trace: built-in: git show-ref --verify --quiet refs/heads/main
22:51:44.500696 git.c:460               trace: built-in: git fetch --quiet
22:51:45.516015 run-command.c:655       trace: run_command: git fsmonitor--daemon start
22:51:45.537580 git.c:460               trace: built-in: git fsmonitor--daemon start
22:51:45.538566 run-command.c:655       trace: run_command: git fsmonitor--daemon run --detach --ipc-threads=8
22:51:45.572226 run-command.c:655       trace: run_command: GIT_DIR=.git git remote-https origin https://github.com/zsh-users/zsh-completions
22:51:45.585771 git.c:750               trace: exec: git-remote-https origin https://github.com/zsh-users/zsh-completions
22:51:45.586049 run-command.c:655       trace: run_command: git-remote-https origin https://github.com/zsh-users/zsh-completions
22:51:46.123580 run-command.c:655       trace: run_command: git rev-list --objects --stdin --not --all --quiet --alternate-refs
22:51:46.155703 run-command.c:1524      run_processes_parallel: preparing to run up to 4 tasks
22:51:46.155747 run-command.c:1551      run_processes_parallel: done
22:51:46.171417 git.c:460               trace: built-in: git log --color --abbrev-commit --date=short --graph '--pretty=format:%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cd) %C(bold blue)<%an>%Creset' ..FETCH_HEAD
22:51:46.196768 git.c:460               trace: built-in: git pull --recurse-submodules --ff-only origin master
22:51:46.206662 run-command.c:655       trace: run_command: git fetch --update-head-ok --recurse-submodules=on origin master
22:51:46.214505 git.c:460               trace: built-in: git fetch --update-head-ok --recurse-submodules=on origin master
22:51:46.221192 run-command.c:655       trace: run_command: GIT_DIR=.git git remote-https origin https://github.com/zsh-users/zsh-completions
22:51:46.228723 git.c:750               trace: exec: git-remote-https origin https://github.com/zsh-users/zsh-completions
22:51:46.228838 run-command.c:655       trace: run_command: git-remote-https origin https://github.com/zsh-users/zsh-completions
22:51:46.758159 run-command.c:655       trace: run_command: git rev-list --objects --stdin --not --all --quiet --alternate-refs
22:51:46.791379 run-command.c:1524      run_processes_parallel: preparing to run up to 4 tasks
22:51:46.791409 run-command.c:1551      run_processes_parallel: done
22:51:46.821470 run-command.c:655       trace: run_command: git submodule update --recursive --checkout
22:51:46.833993 git.c:750               trace: exec: git-submodule update --recursive --checkout
22:51:46.834216 run-command.c:655       trace: run_command: git-submodule update --recursive --checkout
22:51:46.882491 git.c:460               trace: built-in: git rev-parse --git-dir
22:51:46.889329 git.c:460               trace: built-in: git rev-parse --git-path objects
22:51:46.901872 git.c:460               trace: built-in: git rev-parse --show-prefix
22:51:46.907369 git.c:460               trace: built-in: git rev-parse --show-toplevel
22:51:46.916700 git.c:460               trace: built-in: git submodule--helper update --recursive --checkout --
22:51:46.928801 run-command.c:1524      run_processes_parallel: preparing to run up to 4 tasks
22:51:46.928808 run-command.c:1551      run_processes_parallel: done

In above logs, there is two same logs:

22:51:45.586049 run-command.c:655 trace: run_command: git-remote-https origin https://github.com/zsh-users/zsh-completions
22:51:46.228838 run-command.c:655 trace: run_command: git-remote-https origin https://github.com/zsh-users/zsh-completions

and source code, I think these each two line is original stuff.

first:

zi/lib/zsh/autoload.zsh

Line 1444 in 572553b

command git fetch --quiet && \

second:

zi/lib/zsh/autoload.zsh

Line 1512 in 572553b

command git pull --recurse-submodules ${=ice[pullopts]:---ff-only} origin ${ice[ver]:-$main_branch} |& command grep -E -v '(FETCH_HEAD|up.to.date\.|From.*://)'

In first line, git fetch is used for showing changelogs and second is for updating.
So how about using git merge remotes/origin/master instead of git pull to make network access only 1 time?

[ss-o]

Thanks, for pointing this out, I will check and update you on this. 👍

[onokatio]

@ss-o Do you think this is reasonable? if so, I'll create PR.