Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal cannot be shown on windows #92

Open
1 task
jon-si opened this issue Sep 13, 2024 · 0 comments
Open
1 task

Terminal cannot be shown on windows #92

jon-si opened this issue Sep 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jon-si
Copy link
Collaborator

jon-si commented Sep 13, 2024

System information:

OS: Windows 11 10.0.22631

CPU: (16) x64 AMD Ryzen 7 5700U with Radeon Graphics

Memory: 2.01 GB / 15.34 GB

Binaries:

  • Node: 20.15.0 - C:\Program Files\nodejs\node.EXE

  • npm: 10.8.3 - C:\Program Files\nodejs\npm.CMD

  • node-pty - 1.0.0

Issue Description

The package used for the in-app terminal, specifically node-pty, seems to be a package that is not compatible with Windows (other team members on Macbooks had no issues). This issue also seems to be a common, existing issue, documented here on the node-pty github page.

This is the current error show upon install attempt:

npm install --save node-pty

npm error code 1
npm error path C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty
npm error command failed
npm error command C:\WINDOWS\system32\cmd.exe /d /s /c node-gyp rebuild
npm error C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(504,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c [C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\conpty.vcxproj]
npm error C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(504,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c [C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\conpty_console_list.vcxproj]
npm error Agent.cc
npm error AgentCreateDesktop.cc
npm error ConsoleFont.cc
npm error ConsoleInput.cc
npm error ConsoleInputReencoding.cc
npm error ConsoleLine.cc
npm error DebugShowInput.cc
npm error DefaultInputMap.cc
npm error EventLoop.cc
npm error InputMap.cc
npm error LargeConsoleRead.cc
npm error NamedPipe.cc
npm error Scraper.cc
npm error Terminal.cc
npm error Win32Console.cc
npm error Win32ConsoleBuffer.cc
npm error main.cc
npm error BackgroundDesktop.cc
npm error Buffer.cc
npm error DebugClient.cc
npm error GenRandom.cc
npm error OwnedHandle.cc
npm error StringUtil.cc
npm error WindowsSecurity.cc
npm error WindowsVersion.cc
npm error WinptyAssert.cc
npm error WinptyException.cc
npm error WinptyVersion.cc
npm error win_delay_load_hook.cc
npm error Generating code
npm error Previous IPDB not found, fall back to full compilation.
npm error C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\deps\winpty\src\agent\Agent.cc(231): warning C4722: 'Agent::~Agent': destructor never returns, potential memory leak [C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\deps\winpty\src\winpty-agent.vcxproj]
npm error All 1719 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
npm error Finished generating code
npm error winpty-agent.vcxproj -> C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\Release\winpty-agent.exe
npm error AgentLocation.cc
npm error winpty.cc
npm error BackgroundDesktop.cc
npm error Buffer.cc
npm error DebugClient.cc
npm error GenRandom.cc
npm error OwnedHandle.cc
npm error StringUtil.cc
npm error WindowsSecurity.cc
npm error WindowsVersion.cc
npm error WinptyAssert.cc
npm error WinptyException.cc
npm error WinptyVersion.cc
npm error win_delay_load_hook.cc
npm error Creating library C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\Release\winpty.lib and object C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\Release\winpty.exp
npm error Generating code
npm error Previous IPDB not found, fall back to full compilation.
npm error All 1038 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
npm error Finished generating code
npm error winpty.vcxproj -> C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\Release\winpty.dll
npm error C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(504,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c [C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\pty.vcxproj]
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | win32 | x64
npm error gyp info find Python using Python version 3.9.13 found at "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python.exe"
npm error gyp info find VS using VS2022 (17.7.34031.279) found at:
npm error gyp info find VS "C:\Program Files\Microsoft Visual Studio\2022\Community"
npm error gyp info find VS run with --verbose for detailed information
npm error gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python.exe
npm error gyp info spawn args [
npm error gyp info spawn args 'C:\Users\jonat\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\gyp_main.py',
npm error gyp info spawn args 'binding.gyp',
npm error gyp info spawn args '-f',
npm error gyp info spawn args 'msvs',
npm error gyp info spawn args '-I',
npm error gyp info spawn args 'C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build\config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args 'C:\Users\jonat\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args 'C:\Users\jonat\AppData\Local\node-gyp\Cache\20.15.0\include\node\common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=C:\Users\jonat\AppData\Local\node-gyp\Cache\20.15.0',
npm error gyp info spawn args '-Dnode_gyp_dir=C:\Users\jonat\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=C:\\Users\\jonat\\AppData\\Local\\node-gyp\\Cache\\20.15.0\\<(target_arch)\\node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty\build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp info spawn C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.exe
npm error gyp info spawn args [
npm error gyp info spawn args 'build\binding.sln',
npm error gyp info spawn args '/clp:Verbosity=minimal',
npm error gyp info spawn args '/nologo',
npm error gyp info spawn args '/p:Configuration=Release;Platform=x64'
npm error gyp info spawn args ]
npm error gyp ERR! build error
npm error gyp ERR! stack Error: C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.exe failed with exit code: 1
npm error gyp ERR! stack at ChildProcess. (C:\Users\jonat\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:216:23)
npm error gyp ERR! stack at ChildProcess.emit (node:events:519:28)
npm error gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
npm error gyp ERR! System Windows_NT 10.0.22631
npm error gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\jonat\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
npm error gyp ERR! cwd C:\Users\jonat\OneDrive\Desktop\osp project\super-kuber\node_modules\node-pty
npm error gyp ERR! node -v v20.15.0
npm error gyp ERR! node-gyp -v v10.2.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: C:\Users\jonat\AppData\Local\npm-cache_logs\2024-09-13T14_47_55_106Z-debug-0.log

Reproduction

To reproduce, simply run npm install on the root directory of the app.

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to fix this bug!
@jon-si jon-si added the bug Something isn't working label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant