Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not processed correctly if directory name in path contains "." #108

Open
Tracked by #18
MajorLift opened this issue Feb 8, 2022 · 0 comments
Open
Tracked by #18

Comments

@MajorLift
Copy link

MajorLift commented Feb 8, 2022

Steps to reproduce the behavior:

A. Module not recognized as file

  1. Load a js/ts file containing a static import statement where the source path contains one or more directories using "." in its name
    e.g. import { foo, bar } from '../example.directory/module';
  2. The imported live bindings show up on the Sapling tree as having been exported from non-files.

Screen Shot 2022-02-08 at 10 48 01

B. Input file node flagged as error

  1. Load js/ts file into Sapling that has a path containing one or more directories "." with in its name.
  2. Root node is flagged with error coloring (but open file icon is functional).

Screen Shot 2022-02-09 at 14 39 46

Expected behavior

File path parsing module handles this edge case correctly and icons for opening source files show up on the relevant Sapling tree nodes with no errors.

Desktop:

  • OS: Darwin Kernel Version 21.3.0; root:xnu-8019.80.24~20/RELEASE_ARM64_T8101
  • Version: v1.2.0
@MajorLift MajorLift changed the title Module not recognized as file if directory name in path contains "." Module not processed correctly if directory name in path contains "." Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant