Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back End: 'Code Review Ratio' metric data is abnormal in the 'apache pulsar' repository #49

Open
lishengbao opened this issue Jun 30, 2023 · 2 comments
Open

Back End: 'Code Review Ratio' metric data is abnormal in the 'apache pulsar' repository #49

lishengbao opened this issue Jun 30, 2023 · 2 comments
Assignees
@eyehwan @lishengbao

Comments

@lishengbao
Copy link
Contributor

By Asaf Mesika description. Something doesn’t make sense in this panel , I know for a fact that this project forces PR reviews. How can it be the percentage is so harsh - 50%

image

By looking at Compass's algorithm, for example: apache/pulsar#13586 , this pr has no review comment, so it is not counted, but this pr has been reviewed and approved by @tuteng. Compass will fix this situation later
@lishengbao
Copy link
Contributor Author

Add a code_review_approved_ratio(approved PRs have 0 comments) as a reference metric.

@eyehwan
Copy link
Member

eyehwan commented Sep 26, 2023

@lishengbao I remember this issue has been solved, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyehwan eyehwan

@lishengbao lishengbao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyehwan @lishengbao