ostree admin kargs edit-in-place assertion reached when deployments are pending
#2679
Comments
|
This is lower priority as this should not happen in the currently planned use case but it would be great to not have ostree crash and exit cleanly instead. |
|
Thanks @travier for your report! Maybe should skip pending deployments? (https://github.com/ostreedev/ostree/blob/main/src/libostree/ostree-sysroot-deploy.c#L3618) |
|
I'd say yes, skip pending deployments |
|
A warning should be enough |
|
I had to actually go look at the code for this, but it's worth noting that staged deployments today capture override kargs. So in theory, we should also apply edits to those I think. For example, let's try e.g.: The desired behavior is to have both i.e. |
|
Implementing this will require deserializing the staged deployment (see |
|
Thanks @cgwalters and @travier for the suggestion, will do this when I finish my handy task |
|
Indeed, make sense to apply to the pending deployment too. |
deployments are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=rw ``` After reboot we get both `foo=bar rw`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=foobar ``` After reboot we get both `foo=bar foobar`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=foobar ``` After reboot we get both `foo=bar foobar`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=foobar ``` After reboot we get both `foo=bar foobar`. Fix ostreedev#2679
are pending This is to support pending deployments instead of rasing assertion. For example: ``` $ sudo rpm-ostree kargs --append=foo=bar $ sudo ostree admin kargs edit-in-place --append-if-missing=foobar ``` After reboot we get both `foo=bar foobar`. Fix ostreedev#2679
See #2664:
The text was updated successfully, but these errors were encountered: