Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR check for whether go mod tidy produces a diff #300

Open
eversC opened this issue Jan 15, 2021 · 0 comments
Open

Add PR check for whether go mod tidy produces a diff #300

eversC opened this issue Jan 15, 2021 · 0 comments

Comments

@eversC
Copy link
Collaborator

eversC commented Jan 15, 2021

I think go build will need to be checked in the same way

The goreleaser job in circleci is quite flakey, I'm sure there's various reasons, including go versions being used by people locally that doesn't match that of the circleci jobs.

If after running go mod tidy or go build there are changes to go.mod or go.sum, the check should fail (as eventually go releaser would end up failing when a new tag is pushed and the release circleci job runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant