Fix node-build-scripts-test failing in validate #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
gluxon
reviewed
Aug 5, 2024
Comment on lines
+12
to
+13
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = dirname(__filename); |
There was a problem hiding this comment.
Does __dirname need to be defined? Curious if this works without it?
There was a problem hiding this comment.
Yeah, this was the first thing I tried but it sadly does not seem to work:
There was a problem hiding this comment.
Oh I see. It looks like that's because we're already opting into Jest's ESM support based on the node:80071 warning. It makes sense that __dirname (a CommonJS feature) isn't available given that. Thanks for trying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6926
Checklist
Changes proposed in this pull request:
This PR resolves failing tests encountered while running the introductory
yarn validatecommand (from the README).The "fix" involved here replaces the use of
import.meta.dirnameincssVariables.test.tswith an alternative method of accessing the current folder path. This method was considered one of the ways to expose__dirnamein an ES module prior to it being added in v20.11.0 (see this article for more context).For some reason,
import.meta.dirnameisundefinedwhen running the test scripts. According to the docs it should be there. The typings assume that it is, but in reality onlyimport.meta.urlis defined.It might be worth investigating why the build system doesn't expose these variables at runtime when they're supposed to exist. Perhaps there is something deeper in webpack config that needs addressing.
I did not encounter the scrollbar test flake described in #6926, so those tests are not addressed here.