Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Request object API documentation refers to "trusted_hosts" - not clear #2987

Closed
dannystaple opened this issue Nov 3, 2018 · 4 comments

Comments

@dannystaple
Copy link

Expected Behavior

At the flask documentation for the request context/object http://flask.pocoo.org/docs/1.0/api/#incoming-request-data many items in the section say "see also trusted_hosts". For example http://flask.pocoo.org/docs/1.0/api/#flask.Request.host.

This should be a link, or obvious where to follow to understand what this is.

Actual Behavior

There isn't a link, and it's not clear what the see also is referring to (perhaps in werkzeug?)

Environment

http://flask.pocoo.org/docs/1.0/api/#incoming-request-data

@lepture
Copy link
Contributor

lepture commented Nov 3, 2018

@davidism
Copy link
Member

davidism commented Nov 3, 2018

Related to pallets/pallets-sphinx-themes#60. I don't think there's much we can do about this, unless there's something we can adjust with Sphinx's intersphinx extension.

@dannystaple
Copy link
Author

dannystaple commented Nov 5, 2018 via email

@davidism
Copy link
Member

davidism commented Nov 5, 2018

No, because we would have to copy all the docs from Werkzeug to insert that.

@davidism davidism closed this as completed Jan 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants