Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setItem throws an exception #42

Open
edwh opened this issue Jan 29, 2015 · 3 comments
Open

setItem throws an exception #42

edwh opened this issue Jan 29, 2015 · 3 comments

Comments

@edwh
Copy link

edwh commented Jan 29, 2015

Great script, thanks. The setItem for the expiration key is not inside a try(), so that can throw an exception without triggering a cache prune.

@zallek
Copy link

zallek commented Jul 15, 2015

👍
Uncatched errors are raised there https://github.com/pamelafox/lscache/blob/master/lscache.js#L259
Would be great to find a fix.

@zallek
Copy link

zallek commented Jul 15, 2015

Maybe trying to set the expiration date in the try statements.

@zallek
Copy link

zallek commented Oct 7, 2015

This issue is solved in https://github.com/mWater/ls-cache fork.
And bucket management is smarted:

  • you can flush a bucket and its sub buckets
  • when there is no more space it remove oldest item in all buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants