Slack notifications not passing on commit details

[imclean557]

Using the example slack_notifications.php, the commit ID and message weren't being passed on to Slack. It looks like $fields array wasn't merged properly. To resolve, I changed the following from line 78:

    $fields += array(
      array(
        'title' => 'Commit',
        'value' => rtrim($hash),
        'short' => 'true'
      ),
      array(
        'title' => 'Commit Message',
        'value' => $message,
        'short' => 'false'
      )
    );

To this:

    $fields[] = array(
      'title' => 'Commit',
      'value' => rtrim($hash),
      'short' => 'true'
    );
    $fields[] = array(
      'title' => 'Commit Message',
      'value' => $message,
      'short' => 'false'     
    );

Possibly the numeric keys generated by PHP for the second array start at 0 so are ignored when using +=.

[ccharlton]

Confirmed. After making this change, I now see commit messages in my Slack quicksilver notifications.

[jordan8037310]

Pull request with a fix for this wrapped into #101

[imclean557]

This is still an issue and one I'd regard as fairly major. It prevents both the commit ID and message from ever being displayed in Slack. Could this be separated from the more complicated #101 which appears to have stalled?

[jordan8037310]

Looks like my PR now has conflicts. Unfortunately I don't have time to resolve those directly so perhaps a new PR can be opened to solve this specific issue.

[imclean557]

There were a number of other changes I wanted to make for our usage so I created a new repository. https://github.com/imclean557/slack-pantheon