Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - CodeEditor - loading component not passed to Editor #11033

Open
Ginxo opened this issue Sep 20, 2024 · 0 comments · May be fixed by #11034
Open

Bug - CodeEditor - loading component not passed to Editor #11033

Ginxo opened this issue Sep 20, 2024 · 0 comments · May be fixed by #11034
Labels

Comments

@Ginxo
Copy link

Ginxo commented Sep 20, 2024

Describe the problem
In case loading property is defined this is not considered by the @monaco-editor/react Editor component, just FMPOV it is not passed through.

How do you reproduce the problem?

Just by using the CodeEditor component like

    <CodeEditor
      ...
      loading={<Spinner />}
    />

the spinner is not shown and Loading.. text is shown instead

Expected behavior
To see whatever the component defined on loading property while loading the editor

Is this issue blocking you?
it is not

Screenshots
Screenshot from 2024-09-20 11-36-43

What is your environment?

  • OS: Fedora 40
  • Browser Firefox, chrome
  • Version -

What is your product and what release date are you targeting?
HCM and 25Q1

Any other information?
none

@Ginxo Ginxo added the bug label Sep 20, 2024
@Ginxo Ginxo linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs triage
Development

Successfully merging a pull request may close this issue.

1 participant