Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity causes warnings #13

Open
Sivli-Embir opened this issue Sep 22, 2014 · 5 comments
Open

Velocity causes warnings #13

Sivli-Embir opened this issue Sep 22, 2014 · 5 comments

Comments

@Sivli-Embir
Copy link

After adding velocity I get: Error loading app files Reuse of a collection without replaceParent set Error: Reuse of a collection without replaceParent set. This is not really surprising given how velocity works. Any ideas on how to make PeerDB Velocity friendly?

@mitar
Copy link
Member

mitar commented Sep 22, 2014

Do you know how Velocity works? :-) Care to explain? It seems like it is loading the same file multiple times?

Is there some hook which we could hook into to cleanup before next loading?

How does it address the issue that normal Meteor collections cannot be initialized multiple times? If you do new Meteor.Collection('foo') twice you will also get an error?

@Sivli-Embir
Copy link
Author

I have a very vague idea but I am just starting to dive into it. I do know it is reloading the that app in a mirror copy of meteor. I will keep diving into it and see what I can see. Looking for how they deal with standard Collections is a good idea.

Mostly I just wanted to put it on your radar, as of yet I am only getting warnings and no errors. But I have not started writing tests involving PeerDB so we will see how long that lasts. If I can't find anything I will make an issue in Velocity core referencing this and see if they can help. Does that work with you?

@mitar
Copy link
Member

mitar commented Sep 22, 2014

as of yet I am only getting warnings and no errors

Those warnings are like compilation time warnings. PeerDB is detecting that you are doing something wrong. And I must say that I have no idea what could go wrong for you if you do not address it. That codepath is completely untested and unsupported. Probably things will fall apart if you will want to do instanceof and similar things on documents from the database.

If I can't find anything I will make an issue in Velocity core referencing this and see if they can help. Does that work with you?

@Sivli-Embir
Copy link
Author

I am postponing this in my app. Velocity just has to many issues to be usable right now.

@mitar
Copy link
Member

mitar commented Jan 17, 2015

Is there anything new about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants