Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIFO queues #4068

Open
npalm opened this issue Aug 15, 2024 · 0 comments
Open

Remove FIFO queues #4068

npalm opened this issue Aug 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@npalm
Copy link
Member

npalm commented Aug 15, 2024

Problem

From creation of the module we have offered the ussages of FIFO queues. By default, they are disabled today. The reason for using FIFO is to process messages for repo level in order. THis to ensure scaling happens in a fair order. However, to ensure messages are handled in the right order the 'Message group id` needs to be set.

The webhook lambda is setting this GitHub message id. Meaning the message group is set always unique and the feature had never worked as intended. An obvious solution is set the group id properly.

But since the FIFO queues had never worked as intended the proposal would be a breaking change and remove the FIFO queues completly from the module. Since it had never worked, zero issues are raised and it is useless complexity to maintain.

Solution

Remove all FIFO logic from lambda and terraform. Change should trigger a major release.

@npalm npalm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant