Fix bug #70570: json_encode and var_dump ignore simplexml cdata #12163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sanity check for the behaviour would be nice :)
Sending to master because of potential BC break.
XML_CDATA_SECTION_NODE was simply not handled, handle it the same way as we handle text nodes for consistency reasons.
We introduce the php_sxe_is_inclusive_text_node() helper for text-like nodes. In DOM parlance, these 2 types are called inclusive text nodes. Unfortunately, the fact that we handle CData the same as text now has a technical BC break.
Previously this XML:
resulted in this var_dump output:
However, after this patch (as text is not an element and thus handled specially) we get the following output: