Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the name of the initializer parameter of ReflectionClass::resetAsLazyGhost() #16758

Closed
wants to merge 2 commits into from
Closed

Fix the name of the initializer parameter of ReflectionClass::resetAsLazyGhost() #16758

wants to merge 2 commits into from
+9 −5

Conversation

arnaud-lb
Copy link
Member

No description provided.

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.4 November 11, 2024 19:32
nielsdos
nielsdos approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: php/doc-en#4037 (comment)

@nielsdos
Copy link
Member

Ah looks like you need to update the test: ext/reflection/tests/ReflectionClass_toString_001.phpt

nielsdos
nielsdos approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for realzies ;)

@TimWolla
Copy link
Member

As with #16751 RM approval would make sense: @php/release-managers-84

Girgias
Girgias approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, but needs RM approval, which should hopefully be uncontroversial.

NattyNarwhal
NattyNarwhal approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic changes should be fine IMHO.

@arnaud-lb arnaud-lb closed this in a8151fc Nov 12, 2024
@arnaud-lb
Copy link
Member Author

@php/release-managers-84, based on the discussion in #16805, are you ok to merge this in GA, too? (This was merged after RC4)

@NattyNarwhal
Copy link
Member

I forgot about the rule in release-process before approving before GA. That said, I still think the risk is low with cosmetic changes, so I think it should be OK.

@arnaud-lb
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@nielsdos nielsdos nielsdos approved these changes

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate will be requested when the pull request is marked ready for review kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arnaud-lb @nielsdos @TimWolla @NattyNarwhal @Girgias