Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand localization of distance/user preference across the app #535

Open
ErikGraciosa opened this issue Feb 18, 2024 · 7 comments
Open

Expand localization of distance/user preference across the app #535

ErikGraciosa opened this issue Feb 18, 2024 · 7 comments

Comments

@ErikGraciosa
Copy link
Contributor

Found that the events page text when no events were returned was not toggling km/mi but the buttons to change distance do toggle km/mi. Looking across the app, the activities page does not toggle km/mi.

@ErikGraciosa
Copy link
Contributor Author

Added a draft PR. #536
The distances I added in km are rounding to the nearest nice looking number. It didn't look like the API used a unit currently so the distance change is only presentational and the actual distance is still miles. Probably could refactor this some to reduce the repetition of values but curious if the change is desired or not before getting too far into it.

@RyanTG
Copy link
Collaborator

RyanTG commented Feb 18, 2024

Yeah, I think we just didn't bother with adjusting the distance unit in this case because it didn't seem terribly important. Beth can probably refresh my memory, though.

So I guess the options are:

  • Keep as is
  • Show km or mi but don't actually change the distance value used in the api requests
  • Show km or mi but change the distance value in the api requests

@ErikGraciosa
Copy link
Contributor Author

ErikGraciosa commented Feb 24, 2024

I would also add

  • Fix events page to match units.
    image

@RyanTG
Copy link
Collaborator

RyanTG commented Apr 23, 2024

This PR is open but incomplete. Are you planning to complete it?

@ErikGraciosa
Copy link
Contributor Author

Yes I can promote this from draft. I'll be able to submit in the next few days. I haven't loaded the app locally in a while, I'll likely need a new build. Is there a place to get that from? @RyanTG

@RyanTG
Copy link
Collaborator

RyanTG commented Apr 24, 2024

I'll make new dev builds. Can you shoot an email to admin@pinballmap and then I'll send you the link to it?

@ErikGraciosa
Copy link
Contributor Author

sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants