Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce traffic between deploy-agent and deploy-service #500

Open
mingzhaodotname opened this issue Sep 14, 2017 · 2 comments
Open

Reduce traffic between deploy-agent and deploy-service #500

mingzhaodotname opened this issue Sep 14, 2017 · 2 comments

Comments

@mingzhaodotname
Copy link
Contributor

For each deployment, there are about 8 deployment stages/steps (from PRE_DOWNLOAD to SERVING_BUILD), and for each step the deploy-agent talks to deploy-service to find out what's the next step to do. So, there are at least 8 rounds of traffic for each deployment, which also creates more database access.

Another way to handle each deployment is to let the deploy-agent handle all the deployment stages/steps together and then report back to the deploy-service. In this way, there will be only one or two rounds of communications for each deployment. This would give the deploy-service and also the database less load.

This might be helpful for adding new features, e.g.
#491, where there are concerns about hitting scale limit because of too many database access.

How do you think?

@lilida
Copy link
Contributor

lilida commented Sep 14, 2017

I don't think the round trips in deployment is the bottleneck from our observation. Deployments are not happening all the time. The load here is much much smaller comparing to the regular ping to check if there is a new deployment. Even the latter, from the metric we observed, it can support very large scale

@sulixu
Copy link
Contributor

sulixu commented Sep 14, 2017

@mingzhaodotname there are no increased db query in that pull request. lida's concern is about how to retrieve ec2 tags from host, we don't want to make an ec2 AWS request for every ping request on each host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants