Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #831 broke stale host cleanup for hosts that are part of groups #844

Open
mignaulo opened this issue May 19, 2021 · 1 comment
Open

Comments

@mignaulo
Copy link

We recently upgraded our Teletraan setup to the latest commit from master and ran into issues where hosts stopped getting cleaned up when they where terminated. We were able to revert to the commit just before #831 was merged to restore this functionality. I'm no expert here, here is what I found out by digging into the PR.

The previous version of the cleanup code was split into two parts:

Would it be possible to reintroduce the "cleanup stale hosts that are part of groups" functionality?
(Roughly these lines https://github.com/pinterest/teletraan/pull/831/files#diff-d325e9aa7284f0411829cb75934a0ddae12c7281fda3b09da7779c406e8bad3cL124-L173)

Thanks!

@mignaulo
Copy link
Author

@ankilosaurus apologies for pinging you directly, but you were the author of PR831, which introduced the problem. Would it be possible to reintroduce the functionality that was mistakenly taken out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant