You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I cannot upgrade to React 17 when using PivotalUI components in my codebase. Our test suite (which uses Enzyme) fails on components using PivotalUI components. e.g. OverlayTrigger
Note: there is a high likelihood that Enzyme just doesn't play well when there are varying React version in-play. But that's for another repo/issue.
Describe the solution you'd like
Remove react from the dependencies list (it is already listed under peerDependencies)
Add react to the devDependencies list (it is already listed under peerDependencies)
Try out React 17 and (assuming it will pass) add ^17 to the react semver under peerDependencies
Describe alternatives you've considered
If it is broken, then that's all right. But I would highly encourage at least cleaning up dependencies <=> peerDependencies.
Additional context
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I cannot upgrade to React 17 when using PivotalUI components in my codebase. Our test suite (which uses Enzyme) fails on components using PivotalUI components. e.g. OverlayTrigger
Note: there is a high likelihood that Enzyme just doesn't play well when there are varying React version in-play. But that's for another repo/issue.
Describe the solution you'd like
react
from thedependencies
list (it is already listed underpeerDependencies
)react
to thedevDependencies
list (it is already listed underpeerDependencies
)^17
to thereact
semver underpeerDependencies
Describe alternatives you've considered
If it is broken, then that's all right. But I would highly encourage at least cleaning up
dependencies
<=>peerDependencies
.Additional context
The text was updated successfully, but these errors were encountered: