Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonfiling characters in indicator values #402

Open
nichtich opened this issue Jan 15, 2024 · 2 comments
Open

Nonfiling characters in indicator values #402

nichtich opened this issue Jan 15, 2024 · 2 comments

Comments

@nichtich
Copy link
Collaborator

Field 086, 130, 222, 240, 242, 243, 245, 440, 630, 730, 740, and 830 have indicator definition with codes 0-9 or 1-9, e.g. this. It's a verbatim copy from MARC 21 specification but the actual codes are each of 0,1,2,3...9 instead of the sequence 0-9 or 1-9 (an indicator is only one character anyway). I wonder this has not shown up before on validation.

Solutions:

  • either explicitly list 0 to 9
  • or use a pattern ([0-9]) instead of codes
@nichtich
Copy link
Collaborator Author

nichtich commented Jan 18, 2024

I've started to implement this but

  • changing src/main/java/de/gwdg/metadataqa/marc/definition/tags/tags20x/Tag245.java indicator codes to pattern will make src/test/java/de/gwdg/metadataqa/marc/definition/tags/tags20x/Tag245Test.java fail. I think resolveIndicator in src/main/java/de/gwdg/metadataqa/marc/dao/DataField.java needs to be extended to also handle indicator definitions with pattern.
  • Similar seems to apply for Tag440 and Tag740.

nichtich added a commit that referenced this issue Apr 4, 2024
This makes Avram export from MARC21 valid Avram as discussed in
#405 and
#402.
@pkiraly
Copy link
Owner

pkiraly commented May 31, 2024

  • Investigate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants