Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to reuse tags from other catalogue #507

Open
TobiasNx opened this issue Aug 23, 2024 · 7 comments
Open

How to reuse tags from other catalogue #507

TobiasNx opened this issue Aug 23, 2024 · 7 comments

Comments

@TobiasNx
Copy link

TobiasNx commented Aug 23, 2024

Hi,
we try to reuse the DNB Tags in out hbz catalogue.

I tried it like this, but it does not work: hbz@517869a#diff-6ab233441d2457fd4d4370036d454637fc9ac8133b4d0226ffffa3b206391d18

Is there a way to reuse the dnb Tags?

Thanks

@pkiraly
Copy link
Owner

pkiraly commented Aug 26, 2024

@TobiasNx It is not possible now, unless you copy the classes. But this issue might have a solution: to accept multiple marcVersions, in your case it would be something like: --marcVersion DNB,HBZ - with the functionality that the later overwrites the previous, so let's suppose DNB defined 900, 901 and 902, HBZ defines 902 and 903. The result will be 900, 901 from DNB and 902 and 903 from HBZ. DNB's 902 is overwriten by HBZ's 902.
Would it be acceptable for you?

@TobiasNx
Copy link
Author

Thanks for getting back. Yes i think this could solve the issue. We will try it: hbz@05906fb

@nichtich
Copy link
Collaborator

#368 would help to solve this as well. Having to create and reuse Java classes is more complex than putting together an Avram JSON file.

@TobiasNx
Copy link
Author

#368 would help to solve this as well. Having to create and reuse Java classes is more complex than putting together an Avram JSON file.

Yes, I think so too and I still have a lot of Java Classes to write: hbz#1 (comment)

@Phu2
Copy link
Contributor

Phu2 commented Aug 28, 2024

I tried using --marcVersion DNB,HBZ in our catalogue, see https://github.com/hbz/qa-catalogue/blob/createAdditionalFieldsForHbzPublishingCatalogue/catalogues/hbz-update.sh#L14 but got

Aug 28, 2024 10:11:04 AM de.gwdg.metadataqa.marc.cli.ValidatorCli main
SEVERE: ERROR. Unrecognized marcVersion parameter value: 'DNB,HBZ'

Am i missing something here?

@pkiraly
Copy link
Owner

pkiraly commented Aug 28, 2024

Dear @Phu2, here we just collected ideas, it is not yet implemented. I am working on it, and I will ping you when it will be ready (surely later this week).

@Phu2
Copy link
Contributor

Phu2 commented Aug 28, 2024

Ah i got that wrong, sorry. No hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants