Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline course colour picker #109

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: inline course colour picker #109

wants to merge 1 commit into from

Conversation

pl4nty
Copy link
Owner

@pl4nty pl4nty commented Jan 26, 2022

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-cliff-008e54a00-109.eastasia.azurestaticapps.net

@pl4nty
Copy link
Owner Author

pl4nty commented Jan 26, 2022

There's a strange bug when removing courses with a custom colour, where the course to the left takes on the colour. Only the underlying input changes - not the bootstrap form control, so maybe React rendering at play?

@pl4nty
Copy link
Owner Author

pl4nty commented Jan 26, 2022

Also, a user can't reset an overridden colour. We could use sessionStorage, but the UX wouldn't be clear. Resetting on removal of a course would work, but Typeahead returns all selected (not the changes) so we'd have to find the removed course. This might be useful for later state changes down the track though, so it's my preferred option.

@jthvai
Copy link
Collaborator

jthvai commented Jan 16, 2024

Uh... bump? According to @pl4nty, this PR will be superseded by a complete rewrite of this project, but will remain a draft as it contains useful code.

@jthvai jthvai marked this pull request as draft January 21, 2024 09:50
@jthvai jthvai added the wontfix This will not be worked on label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the colour of a course
2 participants