Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assuming each course code has only one class per session #513

Open
pl4nty opened this issue Jul 15, 2024 · 3 comments
Open

Assuming each course code has only one class per session #513

pl4nty opened this issue Jul 15, 2024 · 3 comments
Labels
bug Something isn't working rewrite Will be addressed in the rewrite

Comments

@pl4nty
Copy link
Owner

pl4nty commented Jul 15, 2024

Category: Issue
Contact:

Originally submitted via the Microsoft Form

@jthvai jthvai changed the title MKTG7260 On Campus Class isn't on the list Assuming each course code only has one class per session Jul 15, 2024
@jthvai jthvai added the bug Something isn't working label Jul 15, 2024
@jthvai jthvai changed the title Assuming each course code only has one class per session Assuming each course code has only one class per session Jul 15, 2024
@jthvai jthvai pinned this issue Jul 15, 2024
@jthvai
Copy link
Collaborator

jthvai commented Jul 15, 2024

Possibly duplicate of #200, but allegedly that issue was resolved?

@jthvai
Copy link
Collaborator

jthvai commented Jul 15, 2024

This might be an issue in the scraper's logic - it might lack the ability to click on multiple classes. It's definitely too late for me to be seriously working on this though so I'll look again tomorrow.

Screenshot of timetabling.anu options

Screenshot from timetabling.anu, of options selected

Screenshot of timetabling.anu output

Screenshot from timetabling.anu, displaying both classes for MKTG7260 as expected


I also wonder whether it might be a issue in the data storage format - the timetable data certainly doesn't have the ability to distinguish between class codes. Though, this might not be the cause of the data loss if it instead combines all events from the same course code (but this is an ugly solution). I haven't managed to find another course with multiple class codes and an entry in timetabling.anu yet. See next comment.

https://github.com/pl4nty/anutimetable/blob/ed81ab058f2ceb036d3bd5a46fc0d9e29bff287f/public/timetable_data/2024/S2.json#L59248-L59288

Edit: wow I can't believe GH is straight up refusing to display this snippet

@jthvai
Copy link
Collaborator

jthvai commented Jul 16, 2024

Reproduced with MNGL1003, MNGL2003, TETM1003, TETM2005

MNGL1003

image

MNGL2003

image

TETM1003

image

TETM2005

image

@jthvai jthvai added the rewrite Will be addressed in the rewrite label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rewrite Will be addressed in the rewrite
Projects
None yet
Development

No branches or pull requests

2 participants