Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy script's check for redis is unreliable #619

Open
xhluca opened this issue Apr 28, 2021 · 0 comments
Open

deploy script's check for redis is unreliable #619

xhluca opened this issue Apr 28, 2021 · 0 comments
Labels
bug something broken infrastructure build process etc. P3 backlog

Comments

@xhluca
Copy link

xhluca commented Apr 28, 2021

Right now, this is how we check if redis is used:

dash-sample-apps/deploy

Lines 107 to 108 in c9c676a

[[ -n "$celery_version" ]] && log-info "celery python version: $(cat "$app_dir/requirements.txt" | grep -E "^celery=")"
[[ -n "$redis_version" ]] && log-info "redis python version: $(cat "$app_dir/requirements.txt" | grep -E "^redis=")"

This is not reliable since I might not include redis inside requirements.txt - in some of the recent apps I had to move all the requirements to another file and install them on the fly with a predeploy.sh script; in this scenario it would've been missed.

@xhluca xhluca changed the title Check for redis is unreliable deploy script's check for redis is unreliable Apr 28, 2021
@gvwilson gvwilson added P3 backlog bug something broken infrastructure build process etc. labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken infrastructure build process etc. P3 backlog
Projects
None yet
Development

No branches or pull requests

2 participants