Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate error message when uploading illegal thumbnail image type #12

Open
Ironman28 opened this issue Apr 7, 2015 · 4 comments
Open

Comments

@Ironman28
Copy link

Currently, uploading an illegal image file type (e.g., TIFF) as a thumbnail does not generate an error message, it simply ignores the upload and the system auto-generates its own thumbnail.

Validation of file type and error messages need implementing.

//////

(unrelated issue: However, I also regularly see newly uploaded clips that have broken thumbnail images. I usually just correct them manually, but something is allowing broken image links to appear in the system without generating an error message or stopping the upload.
An example of a broken thumbnail just appeared! See Ethan Tussey's post titled "Love and Duration" http://www.criticalcommons.org/latestclips
Also here: http://www.criticalcommons.org/@@search?SearchableText=duration&portal_type=PlumiVideo )

@mgogoulos
Copy link
Member

there's no video in http://www.criticalcommons.org/Members/MCIMR/clips/love-and-duration and it appears with a broken image on the listing. The listing should show a default image in such cases

Steve, since the video is uploaded twice http://www.criticalcommons.org/Members/MCIMR/clips/love-and-duration-1 better delete the broken video at http://www.criticalcommons.org/Members/MCIMR/clips/love-and-duration

@ahelme ahelme modified the milestones: spring 2015 sprint, spring 2015 - urgent priority Jun 16, 2015
@ahelme ahelme assigned Ironman28 and mgogoulos and unassigned Ironman28 and mgogoulos Oct 15, 2015
@ahelme
Copy link
Member

ahelme commented Oct 15, 2015

I tested this, and yes the original issue is still a problem:
http://www.criticalcommons.org/Members/anna/clips/test-video-zed-and-two-noughts/video_view

TIFF was ignored, a thumb was generated, but no error message was produced.

(Steve - you might want to delete that video as Markos suggests above)

@Ironman28
Copy link
Author

That video has been deleted!

@ahelme
Copy link
Member

ahelme commented Oct 20, 2015

Okay cool, so just the original issue remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants