Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problematic demos #38

Open
18 of 29 tasks
abernier opened this issue Aug 1, 2024 · 10 comments
Open
18 of 29 tasks

problematic demos #38

abernier opened this issue Aug 1, 2024 · 10 comments

Comments

@abernier
Copy link
Member

abernier commented Aug 1, 2024

Excluding "minor" coloring/lightning/tonmapping issues #11

Here are the "problematic" demos that:

does not build

Some demos/* have been temporarily disabled (renamed "bbuild2" with 2 "b" instead of "build2" like others one) because of build errors.

For them, please test with:

$ npm run -w demos/bvh bbuild2
$ # if succeeded, renane `demos/bvh/package.json#scripts.bbuild2` into `build2`

is blank or error(s) in console

$ npm run -w demos/basic-ballpit dev

something is broken compared to original

@rndexe
Copy link
Contributor

rndexe commented Aug 2, 2024

@rndexe
Copy link
Contributor

rndexe commented Aug 2, 2024

@abernier
Copy link
Member Author

abernier commented Aug 2, 2024

cannot check yourself the ticks in the desc I've written?

@rndexe
Copy link
Contributor

rndexe commented Aug 2, 2024

No, they are disabled

@rndexe
Copy link
Contributor

rndexe commented Aug 8, 2024

Simple physics demo with debug bounds has also been fixed

@abernier
Copy link
Member Author

abernier commented Aug 12, 2024

maybe time for us to remove the ones we cannot migrate, for ex: racing-game is way too big to be included (and maintained...) <= may be a good candidate to remove from examples

@rndexe
Copy link
Contributor

rndexe commented Aug 16, 2024

I've been trying to update these three examples to use vite-plugin-glslify instead of babel plugins
https://pmndrs.github.io/examples/demos/gpgpu-curl-noise-dof
https://pmndrs.github.io/examples/demos/threejs-journey-portal
https://pmndrs.github.io/examples/demos/shader-fire

They build fine in dev and build when running with

npm run -w demos/threejs-journey-portal/ build
npm run -w demos/threejs-journey-portal/ preview

But it doesn't work when building with npm run build && npx serve out

I tried adding the plugin to vite.config.build.ts in packages/e2e/src, but that doesn't work either.

@abernier
Copy link
Member Author

thank you, will check this soon ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants