Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never clear values from _USED_DISPLAY_NR_LIST #83

Open
coderforlife opened this issue Mar 11, 2023 · 3 comments
Open

Never clear values from _USED_DISPLAY_NR_LIST #83

coderforlife opened this issue Mar 11, 2023 · 3 comments

Comments

@coderforlife
Copy link

When a display is stopped, it isn't removed from _USED_DISPLAY_NR_LIST. If displays are continuously started and stopped, this will eventually become impossible to get displays from.

(I have a server that is rendering things on-demand with workers that last a long time).

@ponty
Copy link
Owner

ponty commented Mar 11, 2023

Do you run it on macOS? If yes, what is your XQuartz version?

@coderforlife
Copy link
Author

coderforlife commented Mar 11, 2023 via email

ponty pushed a commit that referenced this issue Mar 12, 2023
@ponty
Copy link
Owner

ponty commented Mar 12, 2023

I fixed it, but can you help with your setup? Distro version, Xvfb -help, Xvfb version.
_USED_DISPLAY_NR_LIST is only used when -displayfd command line option is not available
which was added to Xvfb in 2012.
Do you have a very old system? How is it possible that you don't have -displayfd?

Additional info from README:

"Recent X servers as of version 1.13 (Xvfb, too) support the -displayfd command line option: It will make the X server choose the display itself" https://stackoverflow.com/questions/2520704/find-a-free-x11-display-number/

Version 1.13 was released in 2012: https://www.x.org/releases/individual/xserver/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants