Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of additional Shiny.bindAll() call #36

Closed
cpsievert opened this issue May 23, 2022 · 0 comments · Fixed by posit-dev/py-shiny#174
Closed

Get rid of additional Shiny.bindAll() call #36

cpsievert opened this issue May 23, 2022 · 0 comments · Fixed by posit-dev/py-shiny#174

Comments

@cpsievert
Copy link
Collaborator

Due to rstudio/shiny#3635, ipyshiny currently does this hacky workaround to ensure the output binding has a chance to bind to the DOM after it is registered:

https://github.com/rstudio/ipyshiny/blob/af5402104bc9baa1b5cf3f73dabff38bac6cda34/js/src/output.ts#L75-L81

Once that shiny issue is fixed, we can simply remove the code
cpsievert added a commit to posit-dev/py-shiny that referenced this issue May 23, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36
63039d9
This was referenced May 23, 2022
Merged
Closed
cpsievert added a commit to posit-dev/py-shiny that referenced this issue May 24, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36
ef15acb
@cpsievert cpsievert mentioned this issue May 28, 2022
Closed
cpsievert added a commit to posit-dev/py-shiny that referenced this issue Jun 14, 2022
@cpsievert
Incorporate rstudio/shiny#3638 to address posit-dev/py-shinywidgets#36 (
67350d1 
#174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cpsievert