Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pretty output using node v10.5.0 #113

Open
stephanschubert opened this issue Aug 19, 2018 · 4 comments
Open

No pretty output using node v10.5.0 #113

stephanschubert opened this issue Aug 19, 2018 · 4 comments

Comments

@stephanschubert
Copy link

stephanschubert commented Aug 19, 2018

EDIT: I'm using [email protected] for babel 6.

It's fine using node v8.1.4:

      assert.ok(three * (seven * ten) === three)
                |     |  |     | |    |   |
                |     |  |     | |    |   3
                |     |  |     | 10   false
                |     |  7     70
                3     210

      [number] three
      => 3
      [number] three * (seven * ten)
      => 210


       8 |     const seven = 7;
       9 |     const ten = 10;
    > 10 |     assert.ok(three * (seven * ten) === three);
         |            ^

But after switching to node v10.5.0:

    assert.equal(received, expected) or assert(received)

    Expected value to be equal to:
      true
    Received:
      false

       8 |     const seven = 7;
       9 |     const ten = 10;
    > 10 |     assert.ok(three * (seven * ten) === three);
         |            ^
@stephanschubert
Copy link
Author

Still not working with power-assert 1.6.1 and jest 23.5.0.

@kossnocorp
Copy link

Same here

twada added a commit to twada/pd-power-assert-node-10 that referenced this issue Sep 23, 2018
@twada
Copy link
Member

twada commented Sep 23, 2018

@Jazen @kossnocorp So sorry for my late response.

I've created a small temporal repository for power-assert x Node10 x Jest problem determination but worked as expected with pretty output.

I need your help. Would you create a small repository for reproduction?

@stephanschubert
Copy link
Author

@twada I can't reproduce it anymore...

For others searching for this, here's how my monorepo setup looks like now:

// presets in <root>/.babelrc
{
  "presets": [
    "env",
    "jest",
    "react",
    "power-assert"
  ],
  ...
}

I moved all dev deps into <root>/package.json and switched to exact versioning to avoid any mismatches with packages required as production deps in packages/*/package.json:

    // in <root>/package.json

    "devDependencies": {
      "babel-cli": "6.26.0",
      "babel-core": "6.26.3",
      "babel-jest": "23.6.0",
      "babel-preset-power-assert": "2.0.0",
      ...
      "jest": "23.6.0",
      ...
      "power-assert": "1.6.1",
      ...

...and finally setting them up via npm i && lerna bootstrap --hoist (run in <root>)

HTH, and thank you for taking the time @twada.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants