Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build prestissimo ubuntu docker image failed #23939

Open
unidevel opened this issue Nov 3, 2024 · 2 comments
Open

Build prestissimo ubuntu docker image failed #23939

unidevel opened this issue Nov 3, 2024 · 2 comments
Assignees
Labels

Comments

@unidevel
Copy link

unidevel commented Nov 3, 2024

Your Environment

                   -`
                  .o+`                 
                 `ooo/                 OS: Arch Linux
                `+oooo:                Kernel: x86_64 Linux 6.11.6-arch1-1
               `+oooooo:               Uptime: 3h 19m
               -+oooooo+:              Packages: 1096
             `/:-:++oooo+:             Shell: bash 5.2.32
            `/++++/+++++++:            Resolution: 1920x1200
           `/++++++++++++++:           DE: GNOME
          `/+++ooooooooooooo/`         WM: Mutter
         ./ooosssso++osssssso+`        WM Theme:
        .oossssso-````/ossssss+`       GTK Theme: Adwaita [GTK2/3]
       -osssssso.      :ssssssso.      Icon Theme: Adwaita
      :osssssss/        osssso+++.     Font: Cantarell 11
     /ossssssss/        +ssssooo/-     Disk: 365G / 650G (59%)
   `/ossssso+/:-        -:/+osssso+-   CPU: AMD Ryzen 7 8845HS w/ Radeon 780M Graphics @ 16x 5.137GHz
  `+sso+:-`                 `.-/+oso:  GPU: AMD/ATI
 `++:.                           `-/+/ RAM: 4708MiB / 47594MiB
 .`                                 `/
  • Presto version used: master branch
  • Storage (HDFS/S3/GCS..): when build velox deps with HDFS support
  • Data source and connector used: N/A
  • Deployment (Cloud or On-prem): N/A
  • Pastebin link to the complete debug logs: N/A

Expected Behavior

Build prestissimo ubuntu docker image successfully

Current Behavior

Build failed with error:

+ curl -L https://archive.apache.org/dist/hadoop/common/hadoop-3.3.0/hadoop-3.3.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  477M  100  477M    0     0  1488k      0  0:05:28  0:05:28 --:--:-- 1852k
+ tar -xz --strip-components=1 -f hadoop.tar.gz
+ popd
/build/deps-download /build/deps-download/hawq
+ popd
/build/deps-download/hawq
+ cp -a /build/deps-download/hadoop /usr/local/
+ wget -P /usr/local/hadoop/share/hadoop/common/lib/ https://repo1.maven.org/maven2/junit/junit/4.11/junit-4.11.jar
--2024-11-03 12:18:15--  https://repo1.maven.org/maven2/junit/junit/4.11/junit-4.11.jar
Resolving host.containers.internal (host.containers.internal)... 10.46.1.10
Connecting to host.containers.internal (host.containers.internal)|10.46.1.10|:3128... connected.
Proxy request sent, awaiting response... 200 OK
Length: 245039 (239K) [application/java-archive]
Saving to: '/usr/local/hadoop/share/hadoop/common/lib/junit-4.11.jar'

junit-4.11.jar         100%[==========================>] 239.30K   476KB/s    in 0.5s

2024-11-03 12:18:18 (476 KB/s) - '/usr/local/hadoop/share/hadoop/common/lib/junit-4.11.jar' saved [245039/245039]

+ yum install -y java-1.8.0-openjdk-devel
./velox/scripts/setup-adapters.sh: line 164: yum: command not found
root@114e6d1e256c:/build# apt install yum
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package yum

Possible Solution

In this file https://github.com/prestodb/presto/blob/fc9131c96f1f1fc52bb985855e3caa8ac0ea9822/presto-native-execution/scripts/dockerfiles/ubuntu-22.04-dependency.dockerfile#L33C18-L33C52

Adding ../velox/scripts/setup-adapters.sh with args like ../velox/scripts/setup-adapters.sh aws may fix the error.

Steps to Reproduce

cd presto-native-execution && make submodules
docker compose build ubuntu-native-dependency
@majetideepak
Copy link
Collaborator

Fix being added here facebookincubator/velox#11420

@unidevel
Copy link
Author

unidevel commented Nov 7, 2024

Thanks

facebook-github-bot pushed a commit to facebookincubator/velox that referenced this issue Nov 7, 2024
Summary:
The setup-adapters.sh uses yum when installing OpenJDK 8 during the HDFS installation. This causes errors on non-RHEL/Centos based Linux distributions such as Ubuntu.

The fix is to check for the distribution and select the corresponding package name and package manager.

Addresses: prestodb/presto#23939

Pull Request resolved: #11420

Reviewed By: Yuhta

Differential Revision: D65612082

Pulled By: kevinwilfong

fbshipit-source-id: 1bacde35c4daa87291b198596f61992f290e080f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 Unprioritized
Development

No branches or pull requests

3 participants