Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add "boxed" variant to the Testimonial #829

Open
seangolob opened this issue Nov 21, 2024 · 0 comments
Open

[Feature request] Add "boxed" variant to the Testimonial #829

seangolob opened this issue Nov 21, 2024 · 0 comments

Comments

@seangolob
Copy link

seangolob commented Nov 21, 2024

Hi PB Team!

I have noticed a few pages that have testimonials that have a boxed wrapper around them:

Single Testimonial:

https://github.com/features/actions
https://github.com/features/issues

Image
Image

Two Testimonials:

https://github.com/features/codespaces
https://github.com/features/code-search

Image
Image

Can we consider adding a "boxed" variant to the Testimonial component to support these use cases?

The Single Testimonial page examples have a somewhat transparent background with a blur which should probably exist at the implementation level. However, it would be nice to have the spacing defined in the PB library to have future testimonials share the same spacing.

CC @simmonsjenna CC @jesussandreas

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant