Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display <custodhist> at the component level #1462

Closed
marlo-longley opened this issue Dec 8, 2023 · 4 comments
Closed

Display <custodhist> at the component level #1462

marlo-longley opened this issue Dec 8, 2023 · 4 comments
Assignees

Comments

@marlo-longley
Copy link
Contributor

custodhist

Broken out of #898

@gwiedeman gwiedeman self-assigned this Dec 8, 2023
@gwiedeman
Copy link
Contributor

This one is also already displaying: https://github.com/projectblacklight/arclight/blob/main/lib/generators/arclight/templates/catalog_controller.rb#L327

However, both <custodhist> and processinfo (#1463) are using _html_tesm, so I'm wondering @seanaery if you found examples where the tags within them were something more elaborate than <p>s and they wouldn't display? It looks like this would index whatever, but I wonder if there are cases where odd XML wouldn't display in a browser?

@seanaery
Copy link
Contributor

seanaery commented Dec 8, 2023

@gwiedeman As far as I can tell, all our Duke finding aids that have processinfo or custodhist are composed entirely of head & p tags, BUT I do see that either of those elements by EAD2002 specs can contain elements like chronlist that we have other special formatting rules for, so it may be safest to leave those elements capturing the raw XML (to_text: false) during indexing and piping them through the render_html_tags helper for display.

@gwiedeman
Copy link
Contributor

Ah, I get what that's doing now. I'll have to update #1466 next week then.

@gwiedeman
Copy link
Contributor

This is safe to close then,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants