New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure semantic HTML #3252

Open

jcoyne opened this issue Aug 2, 2024 · 0 comments

Milestone

Member

jcoyne commented Aug 2, 2024 •

edited

Loading

Currently the HeaderComponent contains the search bar. However, I think it would be better semantics to move the search bar into the <main> https://github.com/projectblacklight/blacklight/blob/main/app/views/layouts/blacklight/base.html.erb#L38-L40. This means that the search form, available filters and results are all enclosed in <main> and not split across multiple elements.

Then we could have a structure like this:

<body>
  <header>
  </header>
  <main>
    <search>
       <form><!-- search bar goes here --></form>
       <section><!-- selected options --></section>
       <section><!--facets--></section>
       <section><!--search results--></section>
    </search>
  </main>
 </body>

The text was updated successfully, but these errors were encountered:

jcoyne added this to the 9.X milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment