Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise resource form - Open Pull Request #15

Open
meg-ray opened this issue May 3, 2021 · 4 comments · May be fixed by #44
Open

Revise resource form - Open Pull Request #15

meg-ray opened this issue May 3, 2021 · 4 comments · May be fixed by #44
Labels
good first issue Good for newcomers

Comments

@meg-ray
Copy link
Contributor

meg-ray commented May 3, 2021 •
edited
Loading

Users must fill out a form to add a resource to the database. Some adjustments need to be made to the form including:

  • making it possible to select more than one option from the dropdowns
  • adding help text
  • making the "Requirements" and "License" prompts optional
  • adding the ability to add multiple links and give each link a name.
  • adding a field where users can specify whether the resource is an open source project, an open education resource, free, or freemium
@meg-ray meg-ray changed the title Revise Resource Form Revise resource form May 3, 2021
@meg-ray meg-ray added the good first issue Good for newcomers label May 3, 2021
@sijanonly
Copy link
Collaborator

Hi @meg-ray , I will work on it.

@sijanonly
Copy link
Collaborator

For "adding help text", I am using 'placeholder' in order to include help text.

@sijanonly
Copy link
Collaborator

sijanonly commented May 15, 2021 •
edited
Loading

Need more clarification on following :

1. Making it possible to select more than one option from the dropdowns  -> We have three dropdown fields
   a. Requires signup
   b. user type
   c. python related 

 Do we need to make it multi-select for all these 3 fields?

2. Adding help text (SOLVED)  -> I used the placeholder to solve it.

3. Making the "Requirements" and "License" prompts optional (ALREADY SOLVED ?)  -> There are already optional 

4. Adding the ability to add multiple links and give each link a name.
 -> User can add three links in the current UI. (url1, url2, url3)
 -> We want to allow users to add multiple links?
 -> What do you mean by name? Currently, we have URL/description as fields. We are adding an extra field for 'name'?

5. Adding a field where users can specify whether the resource is an open-source project,
 an open education resource, free, or freemium (ALREADY SOLVED)
 -> I think it's already solved. currently use_type field.

@meg-ray
Copy link
Contributor Author

meg-ray commented May 15, 2021

Per our conversation, updating this issue.

@meg-ray meg-ray changed the title Revise resource form Revise resource form - Open Pull Request May 16, 2021
@sijanonly sijanonly linked a pull request May 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add placeholder for help text in the form fields sijanonly/python-in-edu
2 participants
@sijanonly @meg-ray