Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLOVER viewer for playing Audio #6346

Open
sdellis opened this issue Apr 17, 2024 · 6 comments
Open

Use CLOVER viewer for playing Audio #6346

sdellis opened this issue Apr 17, 2024 · 6 comments

Comments

@sdellis
Copy link
Member

sdellis commented Apr 17, 2024

Doing this will allow us to upgrade the UV in #5778

@tpendragon
Copy link
Contributor

main...clover_for_audio has a quick proof of concept.

The last remaining problem (besides tests) there is that if you look at the Playlist link (https://figgy-staging.princeton.edu/viewer#?manifest=https://figgy-staging.princeton.edu/concern/playlists/09804be6-dbbf-4fe7-b124-34cc6f7bc412/manifest), it doesn't show the other tracks - probably a CSS problem. That link is what gets embedded into Canvas for music reserves for classes.

@tpendragon
Copy link
Contributor

tpendragon commented Apr 17, 2024

Looking into it further, it looks like that also an auth token is generated everything stops working. Unsure what's going on there.

@tpendragon
Copy link
Contributor

Oh I bet this is a Clover bug, it only renders HLS if it ends with .m3u8, but here it ends with ?auth_token=

@tpendragon
Copy link
Contributor

I fixed the not loading the bottom, samvera-labs/clover-iiif#198 will fix rendering HLS with auth tokens.

@tpendragon tpendragon self-assigned this Apr 17, 2024
@tpendragon
Copy link
Contributor

New Clover has those hls fixes. Message here to remind me to update when I'm back from vacation.

@tpendragon
Copy link
Contributor

tpendragon commented May 7, 2024

For Mendel the major blocker is that Clover doesn't have a range browser - there's no table of contents.

We'll talk with the developers of Clover at the IIIF conference to see what they think a good strategy would be.

@tpendragon tpendragon removed their assignment May 7, 2024
@tpendragon tpendragon mentioned this issue Jun 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants